search

zksecurity / noname

Noname: a programming language to write zkapps
https://zksecurity.github.io/noname/
161 stars 35 forks source link

feat: support conversion to arkworks constraints #137

Closed dmpierre closed 1 month ago

dmpierre commented 1 month ago

This PR upstreams the ark-noname code, but using arkworks 3.0. Aims to close 135.

katat commented 1 month ago

Looks great! Thanks @dmpierre

I am not quite sure about the value conversion from the BackendField to the one specified for arkwork ConstraintSystem.

@mimoo may want to take a look also.

dmpierre commented 1 month ago

Looks great! Thanks @dmpierre

I am not quite sure about the value conversion from the BackendField to the one specified for arkwork ConstraintSystem.

@mimoo may want to take a look also.

Indeed, good catch! Just removed using arkworks PrimeField trait.