search

zksecurity / noname

Noname: a programming language to write zkapps
https://zksecurity.github.io/noname/
193 stars 50 forks source link

"improve: error msgs and handling" #209

Closed crypdoughdoteth closed 2 weeks ago

crypdoughdoteth commented 3 weeks ago

Closes #26 - removes panics in favor of clear error messages and improves error handling in some places

crypdoughdoteth commented 3 weeks ago

Quick question: in mast/mod.rs/42:13: should the constructor of ExprMonoInfo panic?

mimoo commented 3 weeks ago

actually I see this is a draft, so let me know when it's good to be merged!

crypdoughdoteth commented 3 weeks ago

Panics are now limited to circuit_writer.rs and some constructors

mimoo commented 3 weeks ago

Lgtm! Thanks so much for the PR!

I'll let @katat merge after looking at https://github.com/zksecurity/noname/pull/209#discussion_r1814037804

katat commented 3 weeks ago

Looks good, thanks! Btw, any ideas on why the test CI failed? @crypdoughdoteth

crypdoughdoteth commented 2 weeks ago

CI should be green now 🫡