search

zksync-association / zksync-upgrade-verification-tool

ZKsync Protocol Proposal Verification CLI & Governance Authentication Web App
MIT License
4 stars 1 forks source link

Update required to use semver in common.json #30

Closed arose00 closed 5 months ago

arose00 commented 5 months ago

Hey team,

The zkSync upgrade common.json file has been updated to use semantic versioning for the protocol version (example here).

Previously it would look like:

{
  "name": "boojum",
  "creationTimestamp": 1699353977,
  "protocolVersion": "18"
}

now it looks like:

{
  "name": "hyperchain-upgrade",
  "creationTimestamp": 1711451944,
  "protocolVersion": "0.24.1"
}

pnpm validate check currently fails because of this change.

tomimor commented 5 months ago

Hi @arose00 ! We are already working on a fix and will let you know as soon as it's ready. Thanks!

tomimor commented 5 months ago

Hi @arose00! With fix #31, you should be able to run the check command with the corresponding version number showing. Now the tool interprets the current version as semantic version.

For example, with hyperchain upgrade:

pnpm validate check ../zksync-era/etc/upgrades/1711451944-hyperchain-upgrade --ref=8a70bbbc48125f5bde6189b4e3c6a3ee79631678

image

Thanks for raising awareness of this issue!