zksync-sdk / zksync-ethers

zksync-ethers is an ethers.js library adapted to work with the ZKsync Era.
Apache License 2.0
24 stars 29 forks source link

set value of "sideEffects" in package.json to false #209

Closed FelixMohr closed 3 weeks ago

FelixMohr commented 1 month ago

What :computer:

Set the value of option "sideEffects" in package.json to false. Same as what ethers.js does: https://github.com/ethers-io/ethers.js/blob/main/package.json

Why :hand:

There are bundled frontend applications that use zksync-ethers. This option will enable tree shaking. Bundles can be organized more efficiently, and in most cases less code will be fetched and parsed by clients, so performance can be improved.

Evidence :camera:

Find more about the option here: https://webpack.js.org/guides/tree-shaking/#clarifying-tree-shaking-and-sideeffects

petarTxFusion commented 3 weeks ago

Please fix failing jobs. Once you do that we can merge this