Closed hukkin closed 3 years ago
These interface being async doesn't seem to achieve anything, but increases API complexity, so I'd suggest making it synchronous.
It all boils down to EthereumSignerWeb3.sign which is an async def function but doesnt await anywhere.
EthereumSignerWeb3.sign
async def
await
This is also consistent with ZkSyncSigner where the sign function is synchronous.
ZkSyncSigner
These interface being async doesn't seem to achieve anything, but increases API complexity, so I'd suggest making it synchronous.
It all boils down to
EthereumSignerWeb3.signwhich is anasync deffunction but doesntawaitanywhere.This is also consistent with
ZkSyncSignerwhere the sign function is synchronous.