Open hukkin opened 3 years ago
Some time ago I fixed a few issues with decimal_str_amount. It was an important function because the output of it was used as input when signing, so any error would result in an invalid signature.
decimal_str_amount
A recent commit (https://github.com/zksync-sdk/zksync-python/commit/c2820a50c0ce1b82f24bdd4d75e92efdf7e1cda4) changes formatting of zero from 0 to 0.0. I remember that this special casing was important for signing to be in sync with https://github.com/matter-labs/zksync
0
0.0
Was there a change in spec, or should this change be reverted?
Some time ago I fixed a few issues with
decimal_str_amount. It was an important function because the output of it was used as input when signing, so any error would result in an invalid signature.A recent commit (https://github.com/zksync-sdk/zksync-python/commit/c2820a50c0ce1b82f24bdd4d75e92efdf7e1cda4) changes formatting of zero from
0to0.0. I remember that this special casing was important for signing to be in sync with https://github.com/matter-labs/zksyncWas there a change in spec, or should this change be reverted?