search

zksync-sdk / zksync-python

Python 3.8 SDK for zkSync
MIT License
116 stars 64 forks source link

implementation of transaction wrapper and tests corrections, fixes #ZSDK-47 #25

Closed vyastrebovvareger closed 2 years ago

StanislavBreadless commented 2 years ago

@vyastrebovvareger please make the ci pass

vyastrebovvareger commented 2 years ago

@vyastrebovvareger please make the ci pass

I tested on my side. Should work. One question. Do I get it correct that I can't run CI test by my own from your repo right?

StanislavBreadless commented 2 years ago

@vyastrebovvareger please make the ci pass

I tested on my side. Should work. One question. Do I get it correct that I can't run CI test by my own from your repo right?

Yeah, the CI requires my approval because you are not in the org

vyastrebovvareger commented 2 years ago

Please run CI tests one more time. I added the comments to the 2 test cases of NFT. Currently I'm using your suggestions to check if the wallet owns any NFT token. Otherwise just ignore the transfering or withdraw. In the future I see that it should be VM or docker with local ZkSync & Eth servers. It allows to manipulate data inside test quickly( check the VERIFIED state of transaction) and so can assing/deposite any type of token to any account for testing

StanislavBreadless commented 2 years ago

@vyastrebovvareger failed :(

StanislavBreadless commented 2 years ago

@popzxc could you please add @vyastrebovvareger to the org so he can run the CI himself?

StanislavBreadless commented 2 years ago

@vyastrebovvareger you should be able now to run the CI

vyastrebovvareger commented 2 years ago

Thank you for access but as far as I can see I need approval first to run the CI tests :(

StanislavBreadless commented 2 years ago

Thank you for access but as far as I can see I need approval first to run the CI tests :(

That's weird, maybe because you are doing that from fork

vyastrebovvareger commented 2 years ago

I did the new PR from the original repo branch and it's working