Blocking sleep operation in async code

zksync-sdk / zksync-python

Python 3.8 SDK for zkSync

MIT License

116 stars 64 forks source link

Blocking sleep operation in async code #29

Closed ColonelJ closed 2 years ago

ColonelJ commented 2 years ago

https://github.com/zksync-sdk/zksync-python/blob/9d2ee3698624d8c97647c8b5d10022d46b86bc86/zksync_sdk/zksync_provider/transaction.py#L37

Don't use time.sleep() in async code. :vomiting_face: It will block the whole event loop! Use await asyncio.sleep(). Please correct this ASAP. Thanks :slightly_smiling_face: