zksync / credo

The Unlicense
2.18k stars 1.05k forks source link

Add support for Thai language #59

Closed richardgreg closed 11 months ago

0xsisyfos commented 1 year ago

Hey @richardgreg

First of all, thank you very much for contributing to the ZK Credo by translating it. We appreciate it greatly, and the community will benefit immensely from your work.

To ensure the quality and consistency of the ZK Credo, we asked a third party to review the translation. We invite you to consider their feedback and make the necessary changes before we accept the PR. Please find the suggestions below. They are suggestions to changes from A (current version) to B (suggested version):

Let me know what you think about these comments, Best,

richardgreg commented 12 months ago

Looks good. Pushing an update ASAP

richardgreg commented 11 months ago

Gentle reminder @0xsisyfos, I've pushed the update. Is there anything else?

0xsisyfos commented 11 months ago

Thank you for this!

You should be able to claim a GitPOAP for contributing to the ZK Credo: https://www.gitpoap.io/gp/1079