search

zktuong / ktplots

Some tools for plotting single-cell data
https://zktuong.github.io/ktplots/
MIT License
162 stars 31 forks source link

remove prep dimensions #105

Closed zktuong closed 7 months ago

zktuong commented 7 months ago

this is causing issue at #101

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c90d6bf) 72.49% compared to head (b9a3354) 73.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #105 +/- ## ========================================== + Coverage 72.49% 73.03% +0.53% ========================================== Files 9 9 Lines 2149 2136 -13 ========================================== + Hits 1558 1560 +2 + Misses 591 576 -15 ``` | [Files](https://app.codecov.io/gh/zktuong/ktplots/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zewen+Kelvin+Tuong) | Coverage Δ | | |---|---|---| | [R/utils.R](https://app.codecov.io/gh/zktuong/ktplots/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zewen+Kelvin+Tuong#diff-Ui91dGlscy5S) | `86.60% <ø> (+1.80%)` | :arrow_up: | | [R/plot\_cpdb.R](https://app.codecov.io/gh/zktuong/ktplots/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zewen+Kelvin+Tuong#diff-Ui9wbG90X2NwZGIuUg==) | `65.44% <85.71%> (+0.38%)` | :arrow_up: |
zktuong commented 7 months ago

hmm i think it's doing the thing where it's pulling in non-relevant interactions...

zktuong commented 7 months ago

doesn't solve the issue of pulling non-significant interactions

zktuong commented 7 months ago

ah ok that's not the issue. changing it to 

df <- df %>%
          dplyr::filter(!is.na(cellsign))

will retrieve the results, but this defeats the purpose of the cellsign filtering. so i need to add another check in the steps that if the significant interaction was removed, then just remove that entire LR.