search

zktuong / ktplots

Some tools for plotting single-cell data
https://zktuong.github.io/ktplots/
MIT License
157 stars 30 forks source link

plot_cpdb_heatmap doesn't support symmetric #69

Closed johan-gson closed 1 year ago

johan-gson commented 1 year ago

Hi and thanks for a nice R package! I see that plot_cpdb_heatmap doesn't support symmetric plots, while the python package does. It would be valuable and appreciated if you could add that, I would be most thankful!

zktuong commented 1 year ago

Thanks @johan-gson. I'm a bit busy at the moment so don't have much time to work on this. Will keep this in mind when i find some time.

johan-gson commented 1 year ago

Sounds good, thanks for the nice R package!

Best,

Johan

On Fri, Mar 31, 2023 at 8:44 PM Zewen Kelvin Tuong @.***> wrote:

Thanks @johan-gson https://github.com/johan-gson. I'm a bit busy at the moment so don't have much time to work on this. Will keep this in mind when i find some time.

— Reply to this email directly, view it on GitHub https://github.com/zktuong/ktplots/issues/69#issuecomment-1492761605, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHX2AKZ2JTMECNFOVCXF5YTW6525HANCNFSM6AAAAAAWOARJTI . You are receiving this because you were mentioned.Message ID: @.***>

zktuong commented 1 year ago

actually it's a lot less work than i thought. testing now at #70 . hopefully merge soon.

johan-gson commented 1 year ago

Very nice, many thanks!

Best,

Johan

On Fri, Mar 31, 2023 at 9:28 PM Zewen Kelvin Tuong @.***> wrote:

actually it's a lot less work than i thought. testing now at #70 https://github.com/zktuong/ktplots/pull/70 . hopefully merge soon.

— Reply to this email directly, view it on GitHub https://github.com/zktuong/ktplots/issues/69#issuecomment-1492776579, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHX2AK5WY5EELKIHZW3IX3DW66AFPANCNFSM6AAAAAAWOARJTI . You are receiving this because you were mentioned.Message ID: @.***>

johan-gson commented 1 year ago

Very nice, thank you!

Den lör 1 apr. 2023 00:26Zewen Kelvin Tuong @.***> skrev:

Closed #69 https://github.com/zktuong/ktplots/issues/69 as completed via #70 https://github.com/zktuong/ktplots/pull/70.

— Reply to this email directly, view it on GitHub https://github.com/zktuong/ktplots/issues/69#event-8903227650, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHX2AK6CN7QYHSD262IM4CTW66U5VANCNFSM6AAAAAAWOARJTI . You are receiving this because you were mentioned.Message ID: @.***>

johan-gson commented 1 year ago

@zktuong Hi, I'm having a problem with this, the python and R versions don't produce the same plot. Any idea why this may be? The second is R

PD1_all_heatmap_sym Heatmap_sym_All_R

zktuong commented 1 year ago

Hi, yes sorry. There was a bug on the python version. The one in R is correct. I’ve updated the python version yesterday as well.

johan-gson commented 1 year ago

Very nice, thanks, good to know!

Best,

Johan

On Sat, Apr 1, 2023 at 4:44 PM Zewen Kelvin Tuong @.***> wrote:

Hi, yes sorry. There was a bug on the python version. The one in R is correct. I’ve updated the python version yesterday as well.

— Reply to this email directly, view it on GitHub https://github.com/zktuong/ktplots/issues/69#issuecomment-1493113492, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHX2AK4TWOGW4QVPBU47KKDW7CHRZANCNFSM6AAAAAAWOARJTI . You are receiving this because you were mentioned.Message ID: @.***>