search

zktuong / ktplots

Some tools for plotting single-cell data
https://zktuong.github.io/ktplots/
MIT License
164 stars 32 forks source link

Update plot_cpdb3.R #94

Closed WeberKang closed 11 months ago

WeberKang commented 11 months ago

factor to character

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8b249e8) 70.47% compared to head (a44dc34) 70.49%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #94 +/- ## ========================================== + Coverage 70.47% 70.49% +0.01% ========================================== Files 9 9 Lines 2161 2162 +1 ========================================== + Hits 1523 1524 +1 Misses 638 638 ``` | [Files](https://app.codecov.io/gh/zktuong/ktplots/pull/94?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zewen+Kelvin+Tuong) | Coverage Δ | | |---|---|---| | [R/plot\_cpdb3.R](https://app.codecov.io/gh/zktuong/ktplots/pull/94?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zewen+Kelvin+Tuong#diff-Ui9wbG90X2NwZGIzLlI=) | `75.70% <100.00%> (+0.11%)` | :arrow_up: |
zktuong commented 11 months ago

Thank you for the PR. I will review it properly next week when i’m back at work

zktuong commented 11 months ago

Hi @WeberKang,

i had a look and this is not the fix required. instead of using 3, i need to change it to the actual column name (means or scaled_means)

WeberKang commented 11 months ago

ok，this is a great tool. wish you a happy holiday!