search

zktuong / ktplotspy

Python library for plotting Cellphonedb results. Ported from ktplots R package.
https://ktplotspy.readthedocs.io/
MIT License
46 stars 12 forks source link

Fix bug Heatmap #18

Closed Tu-feng closed 1 year ago

Tu-feng commented 1 year ago

Hi, after read the R version plot_heatmap, I found a difference in python code. Should take pvals[11:] rather than pvals[12:](first cell-cell interaction in pvalues.csv would be dropped if take [12:]). And I made my code more readable. Could you run a test on this?

Tu-feng commented 1 year ago

I'll check the report

codecov[bot] commented 1 year ago

Codecov Report

Merging #18 (a5a50a4) into master (faa0564) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          558       557    -1     
=========================================
- Hits           558       557    -1
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ktplotspy/plot/plot_cpdb_heatmap.py 100.00% <100.00%> (ø)
zktuong commented 1 year ago

👍🏻