search

zkutalik / ssimp_software

GNU General Public License v3.0
16 stars 10 forks source link

Three small changes #115

Closed aaronmcdaid closed 3 years ago

aaronmcdaid commented 3 years ago
  1. As suggested in #114, this adds two includes for time.h that Peter needed on his machine
  2. While I (Aaron) was compiling this on my oldish laptop (g++ 7.5 from 2017), I found there was a problem with including isnan. So I just had to change two instances of isnan to std::isnan.
  3. I added a bit of code to the compilation process such that it prints the compiler that is being used. I have two C++ compilers on my machine and I wasn't sure which one it was using. It prints something like this:
$ make
....
   Building 'bin/ssimp'

stu/stu bin/ssimp
Building @report_the_compiler_version
============
We have found the following C++ compiler on your system.
This will be used to compile ssimp:

g++ (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

============
...
zkutalik commented 3 years ago

Thanks a lot, Aaron, for your kind help.

I accepted your changes and merged the commit to master.

I truly appreciate you investing into making ssimp better!

Best

Zoltan

On Tue, Jan 26, 2021 at 12:21 AM Aaron McDaid notifications@github.com wrote:

  1. As suggested in #114 https://github.com/zkutalik/ssimp_software/issues/114, this adds two includes for time.h that Peter needed on his machine
  2. While I (Aaron) was compiling this on my oldish laptop (g++ 7.5 from 2017), I found there was a problem with including isnan. So I just had to change two instances of isnan to std::isnan.
  3. I added a bit of code to the compilation process such that it prints the compiler that is being used. I have two C++ compilers on my machine and I wasn't sure which one it was using. It prints something like this:

$ make .... Building 'bin/ssimp'

stu/stu bin/ssimp Building @report_the_compiler_version

We have found the following C++ compiler on your system. This will be used to compile ssimp:

g++ (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 Copyright (C) 2017 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

============ ...

You can view, comment on, or merge this pull request online at:

https://github.com/zkutalik/ssimp_software/pull/115 Commit Summary

  • For issue #114, add two includes to
  • Fix imports of isnan(). They didn't work for me (clang++ v8.0.0)
  • Add a message at the start of the compilation to print which C++ compiler is being used

File Changes

Patch Links:

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/zkutalik/ssimp_software/pull/115, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUPFNMPQPOC4AQOH4BDKYDS3X4H5ANCNFSM4WSQUWPA .