search

zkutalik / ssimp_software

GNU General Public License v3.0
16 stars 10 forks source link

remove all the lambdas that are not controlled by the default #30

Closed aaronmcdaid closed 6 years ago

aaronmcdaid commented 6 years ago

Done.

However, are you certain you want to do this? If I remember correctly, we deliberately decided to use a tiny lambda (1e-8) in some of the calculations, for example when computing the number of effective tests. The number of effective tests is used to compute the correct imputation quality.

Pushed to new branch 'remove.hardcoded.lambdas'

sinarueeger commented 6 years ago

I checked: we need the lambda for the imputation quality itself, as well as for the effective number of tests (incorporated in the impqual). Will merge the branch.

sinarueeger commented 6 years ago

38