search

zkutalik / ssimp_software

GNU General Public License v3.0
16 stars 10 forks source link

Delete SNPs where the two allele names are identical. #70

Closed aaronmcdaid closed 6 years ago

aaronmcdaid commented 6 years ago

This can happen where both are 'na', for example.

aaronmcdaid commented 6 years ago

I also took the opportunity to simplify slightly the implementation of delete_snps_with_no_position.

I say 'simplify', but C++ is weird when it comes to deleting things from a vector

aaronmcdaid commented 6 years ago

@sinarueeger , with these changes (which hopefully fix things), perhaps there should be a new version of ssimp? 0.4.1, or 0.5? I can rebuild the static Linux version as before. Or maybe there are other smalls changes you would like me to look into?

sinarueeger commented 6 years ago

@aaronmcdaid (or @aaron-mcdaid-zalando ?) yes, we should indeed plug this all into version 0.5. Could you update the VERSION file and run the tests? I can then build the mac version and update the README.

aaronmcdaid commented 6 years ago

I'm running all the tests now, I forgot how slow they were :) I'll keep you posted, and I'll make another pull request when it's ready