Issue.59.and.downloads - Githubissues

aaronmcdaid commented 6 years ago

A fix, along with a couple of other things:

I've described the features I've added here in an (unreleased) section at the top of the VERSION. We can see this as a list of features that haven't been recompiled in the binaries yet. Then, when we are ready for the next real version, we can recompiles the binaries and rename (unreleased) to 1.5.3
Fix for issue 59. See the code change here, it's quite small. We now always reimpute and print at least 100 tag SNPs, even if that means it takes more than one window. When we reach 100, the current window is always completed
--download.build.db and --download.1KG. I'm happy with how I've implemented the first one (and not so much the second one), but there is now a lot of repetition in the code.

aaronmcdaid commented 6 years ago

At the moment, we have two PRs. I think that can both safely be merged. But we should then recompile both binaries again, in order to include the code changes in #81, before 'officially' releasing 1.5.2

sinarueeger commented 6 years ago

@aaronmcdaid merged your PR. Will add some examples about the new features '--download.build.db' and '--download.1KG'.

And I wait for your good-to-go about the binary.

zkutalik / ssimp_software

Issue.59.and.downloads #81