search

zkutalik / ssimp_software

GNU General Public License v3.0
16 stars 10 forks source link

add new version #83

Closed sinarueeger closed 6 years ago

sinarueeger commented 6 years ago
aaronmcdaid commented 6 years ago

(I've pushed a change to that script here in the last few seconds)

In the examples script, you have ssimp --download, but that doesn't work as it is ambiguous. It's necessary to do either

`ssimp --download.build.db` or `ssimp --download.1KG`

(You could pass both of them like this: ssimp --download.build.db --download.1KG, but it's kinda redundant as the latter implies the former)

Anyway, you can see the change I've made. I've moved the downloads forward to early in the script to where they are needed

I hope it makes sense! It's a bit complicated)

aaronmcdaid commented 6 years ago

Anyway, all is good otherwise with this PR. Both binaries look good to me. Let's merge!

Also, can you see the releases page in Github? And can you see that we currently have one 'release', for v0.5.1? After merging this, you could make a release for v0.5.2.

A 'release' on the website is just a git tag. It's basically equivalent to running git pull master && git tag v0.5.2 master && git push --tags after you merge in the website