search

zkutalik / ssimp_software

GNU General Public License v3.0
16 stars 10 forks source link

Fix.issue.88 #89

Closed aaronmcdaid closed 6 years ago

aaronmcdaid commented 6 years ago

This should fix issue number 88, I was able to replicate the bug and also to confirm that this fixes it when I run it

Sometimes two tags can have the same position. In that case, we take the average z-score. In another part of the code, I forgot about this and I had mistakenly assert-ed that the number of unique positions was equal to the number of tags. But that's not correct

aaronmcdaid commented 6 years ago

(I'll close this, and open another PR that includes this fix (and other stuff!))