search

zlainsama / CosmeticArmorReworked

This mod allows you to wear two sets of armor, one for display, one for function.
https://minecraft.curseforge.com/projects/cosmetic-armor-reworked
Other
17 stars 18 forks source link

Feature request/bug: CosmeticArmor menu shows (otherwise disabled) vanilla recipe book icon when open #42

Closed kil0byt3 closed 4 years ago

kil0byt3 commented 4 years ago

See screenshots below for issue. In regular inventory, that green book is hidden; with CosmeticArmor GUI open, it's back. Ideally we could have the CosmeticArmor GUI hide the Vanilla recipe book as well. It would be awesome if you could either create a config option in your .cfg to hide the recipe book, or somehow detect if another mod is hiding it and also hide it (harder).

https://github.com/CalaMariGold/Rebirth-Of-The-Night/issues/256

Let me know if you need any info from me :)

zlainsama commented 4 years ago

What mod are you using to hide the book? If I remembered correctly, there was mod that completely disables/hides the book even if it is in modded GUI. It should be easy for me to add a config option to make it hidden.

kil0byt3 commented 4 years ago

Quark. I'll look into other mods - ideally we'd like to keep down on our load order however.

zlainsama commented 4 years ago

Released 1.14.4-v2 and 1.15.2-v2 which added support for disabling the RecipeBook in the CosmeticArmorInventory. The added config option is under server category, you can find the config file in "<the world's save folder>/serverconfig". The reason why it is under server category is to avoid potential de-sync issues. You will need another mod to achieve changing default values in server configs, I'm sorry about this inconvenience.

kil0byt3 commented 4 years ago

Great!! Thank you for your help! Is it possible that this change is backported to the 1.12 version as well, or have you dropped new feature support for that version? No problem if so.

On Apr 20, 2020 at 9:36 AM, <Lain MultipleInstances (mailto:notifications@github.com)> wrote:

Released 1.14.4-v2 and 1.15.2-v2 which added support for disabling the RecipeBook in the CosmeticArmorInventory. The added config option is under server category, you can find the config file in "<the world's save folder>/serverconfig". The reason why it is under server category is to avoid potential de-sync issues. You will need another mod to achieve changing default values in server configs, I'm sorry about this inconvenience.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://github.com/zlainsama/CosmeticArmorReworked/issues/42#issuecomment-616669933), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AJMWNGBWEWUWX6OU4S2DZ33RNR2ZJANCNFSM4MKJ2TSA).

zlainsama commented 4 years ago

Released 1.12.2-v5 with this change. You will need to make sure this setting is same between client and server to avoid potential de-sync issues.

kil0byt3 commented 4 years ago

Thanks a ton!