zlant / parking-lanes

Parking lanes viewer from OpenStreetMap
https://zlant.github.io/parking-lanes/
MIT License
77 stars 13 forks source link

Missing "private" parking and problematic "not applicable" label #150

Open kayD opened 1 year ago

kayD commented 1 year ago

The "not applicable" label in the legend is problematic:

https://zlant.github.io/parking-lanes/#18/49.85138/9.96014 image

The two issues are:

zlant commented 1 year ago

1) "Not applicable" is bad label. I'll rename it to "Unusable" 2) I'll change to "No parking/private"

kayD commented 1 year ago

Please excuse my ignorance, but I don't understand "Unusable":

I thought that the main use case for the map would be the first (people in need of parking space advice). If this is the case, then mapping problems should be visible (as "cannot tell"/"error"), but should not probably not be the most pronounced display.

tordans commented 1 year ago

@zlant I am a bit confused about the code. I thing this might be a mixup from the v1 vs. v2 schema. In the current version (v2-code path) does not use the :condition schema anymore

Former… parking:condition=* tagging was deprecated and should no longer be used.

(Source)

… however the code uses the term condition extensively. The tooltip also still talks about :condition based on the hard coded https://github.com/zlant/parking-lanes/blob/master/src/parking/controls/Legend.tsx#L37

image

However, the tags for the road at https://zlant.github.io/parking-lanes/#18/49.85089/9.95935 are a simple parking:left=no.

image

I think the code for the current (v2) schema actually looks at the physical "parking position" (not the legal aspect) which is defined in https://wiki.openstreetmap.org/wiki/Street_parking#Parking_position as as simple

There is no parking. This refers only to the physical presence of a parking lanes, not the legal condition.

Therefore, the label could be "No parking (unspecified)" indicating that there the legal reason why there is no parking (which would be described by tags like access, fee, restriction… (Wiki)) is not specified.

This label would still make it hard to separate it from the value =no_parking which also says "No parking" but referring to the legal aspect.

Maybe "No parking (no infrastructure)" is better to clarify the reason for the "no".