zlant / parking-lanes

Parking lanes viewer from OpenStreetMap
https://zlant.github.io/parking-lanes/
MIT License
78 stars 13 forks source link

Does the date picker still work? With both data sources? #53

Closed tordans closed 3 years ago

tordans commented 3 years ago

I was wondering how the date feature works after https://github.com/zlant/parking-lanes/pull/52.

But while testing it on https://zlant.github.io/parking-lanes/#17/52.47906/13.42876, I think I was not able to get it to do anything at all.

My assumption was, that it would only work with overpass and that the datepicker should maybe be hidden if the datasource is OSM directly.

zlant commented 3 years ago

This pull request must not affect the work of the date picker. OSM and Overpass data do not differ.

tordans commented 3 years ago

@zlant I might be miss interpreting what this datepicker actually does. Looking at the code, it looks like it changes the styling of based on the date + time? (Picking one of the stylings from the legend based if legend values are conditional, right?)

Do you have an example URL, where that can be seen in action? It looks like in my area no tagging that would effect this change is used.

https://github.com/zlant/parking-lanes/blob/896ad9640465628074ff1bb2b473b015b66bcacb/src/parking/parking-lane.ts#L200-L211

If this is the case, the tooltip for the datepicker would be

Change date to show conditions at this time time of day and day of week. Right?

zlant commented 3 years ago

Do you have an example URL, where that can be seen in action? It looks like in my area no tagging that would effect this change is used.

https://zlant.github.io/parking-lanes/#18/52.47893/13.43178 (this way https://www.openstreetmap.org/way/32118083)