zlant / parking-lanes

Parking lanes viewer from OpenStreetMap
https://zlant.github.io/parking-lanes/
MIT License
77 stars 13 forks source link

Ignore some roads for the editor #66

Open tordans opened 2 years ago

tordans commented 2 years ago

With this change, the following roads will be ignored when loading data for the editor:

At least for Berlin, there should never be parking data needed for those roads, since they are implicitly no parking.

Is this the same where you are mapping? If not, I would change this PR to move those configuration in a local settings file per country.


Update: Converted to draft

I am not sure anymore this change actually does what I want it to do. I would still love to year your feedback on the general idea (and maybe config), but will update here once I know that this is working.

Update 2: The codes does what I want it to do now.

The question is, though, if this is nice enough to be used.

tordans commented 2 years ago

I will leave this as draft, since it's not merge-ready but it would be great to get some feedback on the questions in 'Update 2'.

zlant commented 2 years ago

Road filtering must be here https://github.com/zlant/parking-lanes/blob/master/src/parking/interface.ts#L175 Only roads without parking tags can be ignored