Open tordans opened 2 years ago
I will leave this as draft, since it's not merge-ready but it would be great to get some feedback on the questions in 'Update 2'.
Road filtering must be here https://github.com/zlant/parking-lanes/blob/master/src/parking/interface.ts#L175 Only roads without parking tags can be ignored
With this change, the following roads will be ignored when loading data for the editor:
service=emergency_access
service=parking_aisle
service=driveway
access=private
At least for Berlin, there should never be parking data needed for those roads, since they are implicitly no parking.
Is this the same where you are mapping? If not, I would change this PR to move those configuration in a local settings file per country.
Update: Converted to draft
I am not sure anymore this change actually does what I want it to do. I would still love to year your feedback on the general idea (and maybe config), but will update here once I know that this is working.
Update 2: The codes does what I want it to do now.
The question is, though, if this is nice enough to be used.
A new feature in this branch is https://github.com/zlant/parking-lanes/pull/66/commits/c35e826957cec60c6fe0aef9ffe4741623fec3a6 => What would be a clean way to re-render the dropdown? Or how could this code be refactored to fit into the style of the app? – Or should I remove it again?
https://github.com/zlant/parking-lanes/pull/66/commits/3e273e65f9b2f5329701799ac0308290cb44116b filters the roads described above. => Is this approach OK?
Also, I would love to learn how the data fetching actually works with the osm.org API. Where does the script specify the condition of which data is included? (Like the overpass query did.)