search

zlant / parking-lanes

Parking lanes viewer from OpenStreetMap
https://zlant.github.io/parking-lanes/
MIT License
77 stars 13 forks source link

Add lint and lint:fix to package.json scripts, and pre-commit hook #95

Closed jakecoppinger closed 2 years ago

jakecoppinger commented 2 years ago

Shortcut for command to run and fix (what can be automatically fixed) linter errors.

I also added a pre-commit hook using Husky so this automatically runs before you commit, so it's impossible to commit a change which breaks the typechecker or linter. See README.

The new dev dep in package.json will modify the package-lock.json but I don't know your version of Node - so when I run npm i my package-lock.json is completely changed.

For now this could be fixed by you running npm i and committing the package-lock.json, but a long term solution is https://github.com/zlant/parking-lanes/issues/94 (which I'm happy to implement).

zlant commented 2 years ago

We decided to leave getOverpassEditorQuery in #91

jakecoppinger commented 2 years ago

Yep okay, I'll add an ignore for that function