search

zlargon / google-tts

Google TTS (Text-To-Speech) for node.js
https://www.npmjs.com/package/google-tts-api
MIT License
279 stars 56 forks source link

fix typo #34

Closed kmyk closed 4 years ago

kmyk commented 4 years ago

About the retry feature in the lib/key.js, the comment says "retry after 500 ms" but the actual value is 50 (ms). This pull request fixes this.

For now I increased the interval to 500 ms because I feel that 50 ms is too short as an interval. If the 50 ms was correct and the comment was wrong, please tell me. I'll fix this pull request.

https://github.com/zlargon/google-tts/blob/f7157430d1d8a084e6d43fc10bc643af096d2dee/lib/key.js#L5-L8

https://github.com/zlargon/google-tts/blob/f7157430d1d8a084e6d43fc10bc643af096d2dee/lib/key.js#L26

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 94.737% when pulling b8f514fe98345895e2f531ea4218abb4e4824795 on kmyk:fix/inteval into f7157430d1d8a084e6d43fc10bc643af096d2dee on zlargon:master.

zlargon commented 4 years ago

Ah, that's a typo in the comments, so it should be 50 ms. Thanks.

kmyk commented 4 years ago

Ok, I've updated this pull request.

zlargon commented 4 years ago

Thanks, looks good to me.