search

zlatinb / muwire

MuWire file sharing client for I2P
GNU General Public License v3.0
191 stars 27 forks source link

Poor UI responsiveness if viewing large list of files in search while changing the Trusted status of that user #128

Closed Searinox closed 2 years ago

Searinox commented 2 years ago

Already clicking to view a user's search results in File View mode is slow if there are a lot of them to populate. This is understandable. However, the time it takes to populate this list will hold up the UI again if that user is in your contacts list and you tab to change their status(trusted, neutral, distrusted). I don't see why the entire file view has to be refreshed when we are only changing one cell which is the trusted column. Even if that list was sorted by trusted status, it shouldn't refresh the list of file results.

An easy way to test this is search for something very generic like "the", which will get lots of hits. Select a user with many results with group by File view, wait for their file list to populate, then go to the Contacts tab and attempt to add that person as a contact, or remove them, or change their trust status. The entire UI will freeze up as it repopulates the file list.

zlatinb commented 2 years ago

Good catch, I took a shortcut to refresh all results, but it's only really necessary for the Senders table in group-by-sender and the Senders table in group-by-file. So this can be made a lot faster; I'll try to make the change soon.

zlatinb commented 2 years ago

Ok, I did the changes. Also fixed copy-full-id from the group-by-file view which must have been broken for a while. Build available here

Searinox commented 2 years ago

Confirmed fixed.