search

zlatinb / muwire

MuWire file sharing client for I2P
GNU General Public License v3.0
191 stars 27 forks source link

Deleting Contact kills Muwire #161

Closed JamesOlvertone closed 2 years ago

JamesOlvertone commented 2 years ago

Do this: Browse a contact from your contact list (this user is not connected to muwire) delete this contact while trying to browse his files -> crash:

groovy.lang.MissingMethodException: No signature of method: com.muwire.gui.MainFrameController.removeContact() is applicable for argument types: () values: [] at com.muwire.gui.MainFrameView$_showContactsMenu_closure82.doCall(MainFrameView.groovy:2323) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

zlatinb commented 2 years ago

Thanks for the report I'll take a look as soon as I can. This should happen only when removing from right click menu; the remove contact button should still work.

zlatinb commented 2 years ago

Please try the latest CI build this should now work

JamesOlvertone commented 2 years ago

yes seems to work.

Searinox commented 2 years ago

Fix confirmed.

zlatinb commented 2 years ago

Thanks for confirming!