search

zlatinb / muwire

MuWire file sharing client for I2P
GNU General Public License v3.0
193 stars 27 forks source link

[Question] Direct Sources count in Search Results by File #79

Closed Searinox closed 3 years ago

Searinox commented 3 years ago

In Group By File mode, Searches count the total Direct Sources based on how many times that exact file is found across users, even if it is shared multiple times by the same user.

Now with the advent of folder paths it makes sense to show when a file shows up at multiple locations in a user's share. But the fact that all of those instances add up to the total Direct Sources seems off because that's still a single user you're downloading from.

I think the Direct Sources counter should count the only individual distinct user hits rather than all hits combined.

zlatinb commented 3 years ago

That's an old bug or more precisely design flaw, happens in group-by-sender too. I need to fix it just haven't figured out exactly how.

zlatinb commented 3 years ago

I think I fixed it in https://muwire.com/downloads/MuWire-0.8.9-GitHub79.zip

Searinox commented 3 years ago

I went ahead and made a few checks and really everything seems to be okay.