search

zlatko-minev / pyEPR

Powerful, automated analysis and design of quantum microwave chips & devices [Energy-Participation Ratio and more]
https://pyepr-docs.readthedocs.io
Other
160 stars 219 forks source link

Add other parametric sweep options #117

Closed zachparrott closed 2 years ago

zachparrott commented 2 years ago

Expanded parametric create_setup() to include the other Ansys supported variable sweep definitions and parametric from file. Added additional options for swp_type under setup_type 'parametric' and added setup_type 'parametric_file'.

Let me know if anything is needed or I started the PR incorrectly, don't see a contributing doc and this is my first PR... Only the commit "Implemented all..." changes anything.

zachparrott commented 2 years ago

@zlatko-minev @ThomasGM4 @nikosavola @priti-ashvin-shah-ibm, Does someone mind taking a look at this PR?

ThomasGM4 commented 2 years ago

It looks good to me. Maybe an example notebook showing the new feature added in the tutorials folder would be good?

zachparrott commented 2 years ago

Thanks for feed back @ThomasGM4, I added a tutorial notebook showing example for each of the added sweep types.

ThomasGM4 commented 2 years ago

Nice! I haven't had time to run through the notebook yet but will try to before the long weekend.