search

zlatko-minev / pyEPR

Powerful, automated analysis and design of quantum microwave chips & devices [Energy-Participation Ratio and more]
https://pyepr-docs.readthedocs.io
Other
160 stars 219 forks source link

Sign of junctions will not print correctly #128

Open zachparrott opened 2 years ago

zachparrott commented 2 years ago

Noticed this with the recent fix of the calc_current_using_line_voltage, _Smj will always return true, need > 0 to get it to correctly print "(-)" when appropriate.

Currently: https://github.com/zlatko-minev/pyEPR/blob/0ac3fa2213d2ef6dacd1d2f487ef345cebee235b/pyEPR/core_distributed_analysis.py#L1028

Should change to something like: f'\t{j_name:<15} {pmj_ind:>8.6g}{("(+)"if _Smj > 0 else "(-)"):>5s} {pmj_cap:>8.6g}')

github-actions[bot] commented 2 years ago

👏👏👏 You are awesome! Thank you for making your first issue to pyEPR ' first issue