search

zlavere / GroupAWeatherAnalysis

0 stars 0 forks source link

Possible code consistancey issue in WeatherInfoCollection. #42

Open Weemies opened 5 years ago

Weemies commented 5 years ago

In WeatherInfoCollection groupByMonth is public, and groupByYear is private. Should group by year be public as it is the kind of thing that would be useful if we are keeping extension in mind?

zlavere commented 5 years ago

Good point, let's make them public full properties where get runs the associated LINQ

This could be applicable throughout.a