zlepper / itlt

It's the little things mod, a mod about the little things.
MIT License
12 stars 5 forks source link

itlt gets blamed for other mod's crashes in certain situations #34

Closed PaintNinja closed 2 years ago

PaintNinja commented 2 years ago

Describe the bug itlt gets blamed for other mod's crashes in the crash report when showing the Forge error screen.

To Reproduce Steps to reproduce the behavior:

  1. Install a mod that is marked as 1.18-only
  2. Install itlt 1.18.x-2.1.0
  3. The mod from step 1 will fail due to being declared as 1.18-only and Forge being 1.18.2
  4. On showing the Forge error screen to notify the user of this in the GUI, itlt crashes as the Forge config system isn't activated in this state and returns null to itlt unexpectedly

Expected behavior For the Forge error screen to be shown for the incompatible mod and the crash report to not mention itlt.

Environment details

Logs and additional context Looks like I'll need to put in some extra null checks and special handling in my usage of Forge's config system.

crash-2022-03-08_09.09.49-client.txt crash-2022-03-08_09.09.49-fml.txt latest.log