Closed kloczek closed 3 years ago
can confirm the exact same result, though I have ZSTD 1.4.8 and OPENSSL 1.1.1i installed (not that it matters much in this context).
It's always Error -117 ( MZ_SIGN_ERROR ), sometimes additionally -105 ( MZ_CRC_ERROR )
same pattern of failing tests with any 3.x version ..
For signing tests I believe you have to install the test certificate on your machine. See the .github/workflows/main.yaml
for the commands on your platform to install it.
Which one certifacate is necessary here?
test/test.pem
test/test.pem
And how can I obtain that file?
It's in the repository.
Aaaa .. so minizip-ng has bug because I'm not building in place but off source tree and test suite is not able to find that pem file in current directory. Please try below to reproduce what I'm observing
cmake build
make -C build
make -C build test
https://cmake.org/cmake/help/latest/variable/CMAKE_SOURCE_DIR.html
Did you see my comment where I mentioned you have to install the certificate?
If you still think you have found a bug please submit a PR with the changes. Thank you.
Did you see my comment where I mentioned you have to install the certificate?
If you still think you have found a bug please submit a PR with the changes. Thank you.
OK so you've missed what is on the top of this ticket which point on that I'm using off-tree build -B <builddir>
and
[tkloczko@barrel minizip-ng-3.0.2]$ cmake -L x86_64-redhat-linux-gnu`
Did you try ever that kind of build?
Out of source build is run as part of GitHub Actions. https://github.com/zlib-ng/minizip-ng/runs/2934791517?check_suite_focus=true
Cannot find where actrually is used that pen file.
[tkloczko@barrel minizip-ng-3.0.2]$ grep -r test.pem
.github/workflows/main.yml: run: sudo security add-trusted-cert -d -r trustRoot -k /Library/Keychains/System.keychain test/test.pem || true
.github/workflows/main.yml: run: certutil -addstore -enterprise Root test/test.pem
.github/workflows/main.yml: SSL_CERT_FILE: test.pem
Any hint?
Just turn off signing if you are not using it. cmake .. -DMZ_SIGNING=OFF
.
Swiping something under the carpet is not an option.
Other thing is that in CI is not used -B <builddir>
so it is difference.
Neverteless cannot find where is hardcoded path to test.pem. Can you help at least with that?
Nothing is being swept under the rug. It is tested and works in GitHub Actions CI environment.
Configure source tree:
Result of the source tree configuration:
and test suite execution: