Closed GeckoEidechse closed 3 months ago
When setting the tag to v1.3
(https://github.com/madler/zlib/tree/v1.3) other issues arise, potentially related to the fact that we submodule minizip?
1> [CMake] -- NS: Building to C:/Users/Spoon/NorthstarLauncher/build/game
1> [CMake] -- curl version=[7.81.0-DEV]
1> [CMake] -- Could NOT find ZLIB (missing: ZLIB_LIBRARY ZLIB_INCLUDE_DIR)
1> [CMake] -- Enabled features: SSL IPv6 unixsockets AsynchDNS Largefile SSPI alt-svc HSTS SPNEGO Kerberos NTLM
1> [CMake] -- Enabled protocols: HTTP HTTPS
1> [CMake] -- Enabled SSL backends: Schannel
1> [CMake] -- Using CMake version 3.25.1-msvc1
1> [CMake] -- Fetching zlib https://github.com/madler/zlib v1.3
1> [CMake] HEAD is now at 09155ea zlib 1.3
1> [CMake] Index was not unstashed.
1> [CMake] The stash entry is kept in case you need it again.
1> [CMake] The stash entry is kept in case you need it again.
1> [CMake] CMake Error at C:/Users/Spoon/NorthstarLauncher/build/_deps/zlib-subbuild/zlib-populate-prefix/tmp/zlib-populate-gitupdate.cmake:264 (message):
1> [CMake]
1> [CMake]
1> [CMake] Failed to unstash changes in: 'C:/Users/Spoon/Desktop/Northstar
1> [CMake] Things/Northstar Github
1> [CMake] Fork/NorthstarLauncher/primedev/thirdparty/minizip/third_party/zlib'.
1> [CMake]
1> [CMake] You will have to resolve the conflicts manually
1> [CMake]
1> [CMake]
1> [CMake] [0/7] Performing update step for 'zlib-populate'
1> [CMake] FAILED: zlib-populate-prefix/src/zlib-populate-stamp/zlib-populate-update C:/Users/Spoon/NorthstarLauncher/build/_deps/zlib-subbuild/zlib-populate-prefix/src/zlib-populate-stamp/zlib-populate-update
1> [CMake] cmd.exe /C "cd /D "C:\Users\Spoon\Desktop\Northstar Things\Northstar Github Fork\NorthstarLauncher\primedev\thirdparty\minizip\third_party\zlib" && "C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -P "C:/Users/Spoon/NorthstarLauncher/build/_deps/zlib-subbuild/zlib-populate-prefix/tmp/zlib-populate-gitupdate.cmake""
1> [CMake] ninja: build stopped: subcommand failed.
Corresponding issue on zlib repo: https://github.com/madler/zlib/issues/915
https://github.com/madler/zlib/issues/915 is closed as the changes made to develop branch. how to pick up the change here to fix this issue?
I was able to compile with the tag set to develop
as a workaround.
It is an error in zlib's current CMake in their master
branch. You can delete your temporary build files and try using:
cmake -S . -B build -DZLIB_TAG=develop
I have switched to using zlib-ng.
Since the following commit on zlib (https://github.com/madler/zlib/commit/2e3d86c4e12c4c23db4229eea7d0c1cd4571273e), mini-zip fails building for us.
Truncated output from CI logs: https://github.com/R2Northstar/NorthstarLauncher/actions/runs/7634172734/job/20797658775#step:4:337