search

zlin / wgetpaste

MIT License
34 stars 16 forks source link

Implement bpaste v1 API #16

Closed bcattaneo closed 3 years ago

bcattaneo commented 4 years ago

Solves issue https://github.com/zlin/wgetpaste/issues/15 plus transitioning to JSON in order to use the v1 API (thanks to @mjeveritt suggestion).

mjeveritt commented 4 years ago

This looks good @bcattaneo ! :+1: I think you could probably rebase, and squash those commits into one, as you're only amending your first 'cut' at the API ! :wink:

I'll test it locally to verify all is good here, and then I have good cause to poke our maintainer(s) in Gentoo to push to the new release + patches! :grinning:

Cogitri commented 3 years ago

Ping @bcattaneo

bcattaneo commented 3 years ago

Ping @bcattaneo

Hi!. Was waiting for that other PR to get merged, because there were some notable changes. I'll get my hands back at this asap :)

mjeveritt commented 3 years ago

Ping @bcattaneo

Hi!. Was waiting for that other PR to get merged, because there were some notable changes. I'll get my hands back at this asap :)

Alas I fear that could be a very long wait .. not sure where the lead dev has gone .. :disappointed:

bcattaneo commented 3 years ago

Ping @bcattaneo

Hi!. Was waiting for that other PR to get merged, because there were some notable changes. I'll get my hands back at this asap :)

Alas I fear that could be a very long wait .. not sure where the lead dev has gone .. 😞

Not so fast! 😃 Mind testing locally one more time?

mjeveritt commented 3 years ago

Not so fast! Mind testing locally one more time?

Fine by me here!

Cogitri commented 3 years ago

This branch cannot be rebased due to conflicts

nvinson commented 3 years ago

This branch cannot be rebased due to conflicts

I assume the issue is that feature/bpaste_v1_api contains a merge commit? If so, please take a look at https://github.com/nvinson/wgetpaste/tree/bpaste_v1. With the exception of 1 typographical error fix, this branch should have the same state as feature/bpaste_v1_api and has a merge-commit-less history.

Cogitri commented 3 years ago

Well, doing the following should fix it:

git fetch https://github.com/zlin/wgetpaste.git
git rebase FETCH_HEAD
git push -f
mjeveritt commented 3 years ago

Where are we at with this @nvinson @bcattaneo @Cogitri ?! :smiley:

Cogitri commented 3 years ago

Still conflicts so can't merge this.

mjeveritt commented 3 years ago

@bcattaneo are you OK to revisit the 'jq' stuff now this is merged?! :smiley:

Thanks for the merge! @zlogene for ebuild bump :stuck_out_tongue: