search

zllovesuki / slugsurvival

Source Code for SlugSurvival.com with Cloudflare Workers Site support
https://slugsurvival.com
GNU General Public License v3.0
14 stars 3 forks source link

Moving to vue-loader as vueify is deprecated #22

Closed zllovesuki closed 4 years ago

zllovesuki commented 4 years ago

For some reasons this flew under my radar.. Next on the to-do list.

hyperupcall commented 4 years ago

Hey, is there an update on this? This sounds like something I could possibly help out with, if you are looking for contributors. I assume we would be migrating from a browserify based build system to webpack?

zllovesuki commented 4 years ago

My code is pretty spaghetti at the moment... maybe refactor it before moving to webpack lmao

hyperupcall commented 4 years ago

even if it's a bit messy, i'm close to a working configuration, probably with minimal refactoring. i have a fork here, and can be checked with just the dev2 script. however, it made the browserify build break due to this commit because browserify and webpack resolve commonjs imports from es modules a bit differently. for some reason, the site doesnt seem to be getting past a loading spinner, possibly due to incorrect configuration (i have to look into it more). were you looking to keep the browserify build process or migrate to webpack completely?

zllovesuki commented 4 years ago

Moving to webpack should be the goal. What errors did you encounter in the console? It has some dependency from config.js. Namely, it is taking data from Andromeda.

zllovesuki commented 4 years ago

See src/views/index.vue. The mounted event is not is getting some love. I should take a look at it later. Working on midterm project atm

hyperupcall commented 4 years ago

oye! so i was able to get everything to build and work, for the most part. :smile: on my side, i just need to fix some font errors, properly create builds for production, and maybe work on the webpack development server. the most significant part of the migration was ensuring that we access the .default property of Vue modules that we require. i'll probably get that done in a few days. the code is in the wip/webpack-build-2 branch. and only the npm run prod script is working as intended

hyperupcall commented 4 years ago

also, i saw that you had some babel 6 dependencies in your package.json. i removed them since they didn't seem to be used, but were you looking to add babel? unlike browserify, webpack resolves es module syntax away (if you were thinking about migrating from commonjs to es modules), so we wouldn't need it for that reason, but maybe there is another reason?

zllovesuki commented 4 years ago

I’m not sure why they were in there in the first place, probably polluted the config by npm install in the wrong folder, just like how you forget to activate your virtualenv before pip install 😤

Anyway, thanks for working on this long overdue to-do. I shall check out your code when I’m close to done with my current project on hand.

hyperupcall commented 4 years ago

i just opened a pr so you can review my code. glad i could help out :smiley: