zloop1982 / bwapi

Automatically exported from code.google.com/p/bwapi
0 stars 0 forks source link

UnitType::abilities() should return TechTypes::Burrowing for Zerg_Lurker and Zerg_Infested_Terran #465

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
Call UnitType::abilities() for Zerg_Lurker and Zerg_Infested_Terran.

What is the expected output? What do you see instead?
I expect TechTypes::Burrowing to be included in the set of returned TechType's, 
but it is not.  Note that isBurrowable() returns true for Zerg_Lurker and 
Zerg_Infested_Terran, so it seems inconsistent.

What version of the product are you using? On what operating system?
BWAPI4 on WinXP.

Please provide any additional information below.
In UnitType.cpp when it initializes unitTypeData, unless these initializations 
need to be kept consistent with BW's internal data for some reason, perhaps the 
fix could be to:
* Zerg_Lurker: Change ability2 from TechTypes::None to TechTypes::Burrowing.
* Zerg_Infested_Terran: Change ability1 from TechTypes::None to 
TechTypes::Burrowing.

Original issue reported on code.google.com by chris.c...@gmail.com on 29 Sep 2012 at 1:31

GoogleCodeExporter commented 9 years ago
Actually I haven't rewritten that part yet.

Original comment by AHeinerm on 4 Oct 2012 at 6:38

GoogleCodeExporter commented 9 years ago
This was implemented in r4222 during the rewrite to make UnitType data constant.

Original comment by AHeinerm on 7 Jan 2013 at 3:51