search

zloop1982 / bwapi

Automatically exported from code.google.com/p/bwapi
0 stars 0 forks source link

fixName(std::string *name) doesn't support digits #475

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
BWAPI 3.7.4

In trunk/bwapi/BWAPILIB/Source/Common.cpp:14
there needs to be a case for digits, too.
This breaks for example for the Terran U_238_Shells upgrade

Original issue reported on code.google.com by krasi...@gmail.com on 8 Dec 2012 at 9:01

GoogleCodeExporter commented 9 years ago 
This is not used in BWAPI4. BWAPI4 has its getType (from name) in the base 
class "Type" and accepts digits. The update to BWAPI4 will fix this issue.

Thanks.

Original comment by AHeinerm on 11 Dec 2012 at 7:49