zlsa / atc

https://openscope.co/
342 stars 107 forks source link

False Positives with "appears on collision course with xxx on same rwy" #352

Closed erikquinn closed 8 years ago

erikquinn commented 8 years ago

Last Command entered: DAL672 t r 250 l 28r

image Whenever I really start to push the envelope as far as getting really close to minimum separation on final, I seem to get a bunch of these guys popping up, telling me that the arrivals all appear to be on a collision course together on the same runway. Seems like a false positive to me? I'm not real familiar with how that separation logic works. All I know is that they are separated, and probably shouldn't be generating any warnings to the user.

Side Note: You'll also notice the >30 degree intercept when using heading 250... which is because the actual heading of 28R is 284. I'll check on it, but I'm pretty sure 250 is used at SFO, which would mean that the 30 degree intercept angle is not based on the runway's actual magnetic heading, but its nominal heading, as in 28R --> 28 --> 280 degrees +/- 30 degree intercept. I'll look into it, and create a separate issue if needed.

tedrek commented 8 years ago

Yes the 'appear to be on collision course' warning is a false positive. I made a fairly major mistake there and haven't gotten around to fixing it. The problem is the code is checking if the aircraft are assigned to the same hunk of concrete on the ground and they have headings significantly differing. It should be checking if aircraft are assigned to different ends of the same hunk of concrete (along with distance checks).