search

zlsa / atc

https://openscope.co/
342 stars 107 forks source link

is ATC broken? #444

Closed bolero3232 closed 8 years ago

bolero3232 commented 8 years ago

All I get is the green screen with the circles. No runways, no sids, no names... nothing. Mouse has no effect, no zoom, no move.

Fechulo commented 8 years ago

In which airport are you experiencing this problem?

Fechulo commented 8 years ago

@erikquinn Seems to be a problem with AUA not loading. Could it be have to do with the changes in #431 ?

bolero3232 commented 8 years ago

All airports. What's #431?

bolero3232 commented 8 years ago

431 got it

Fechulo commented 8 years ago

@bolero3232 It's actually not all airports, the problem is that when one airport fails, all airports after it fail too. The problem seems to be in the airports which include Austrian Airlines, which leads me to believe that this is somehow the cause. Since I'm not the expert here, I am not 100% sure.

bolero3232 commented 8 years ago

So what do I do about it?

headphase commented 8 years ago

Testing now and at first I thought it might be due to the uncapitalized "b77l" reference in the fleets of those airlines updated by commit but after recapitalization I'm still having issues with random airports.

Working: KJFK KMSP KSFO KLAX KLAX90 EBBR EDDM EHAM ENGM LTBA SAEZ SBGL SBGR UUDD VHHH

Problems occuring / Loading Failing intermittently: EDDH EDDT EIDW LOWW

Not loading at all (?) EGLC EINN

erikquinn commented 8 years ago

Yeah it's apparently actually due to about a dozen airlines not being called to load. It was like 15 or so, meaning the loading issues would be widespread across the airports, since they all are likely to use one of the affected airlines. Seems impossible that I missed this, as I didn't come across it while testing, but somehow it made it out to the live site. Sorry, this is 100% on me. :disappointed:

I've got them all added in now on a local branch and am just testing the (ahem) stuff out of it before pushing in a hotfix.

headphase commented 8 years ago

Really? That's odd I was looking through airlines.js on the live site and it seems every company is included on the list 👀

erikquinn commented 8 years ago

@headphase Just not some of the new ones from #431 apparently. Four are good, the rest are never loaded in airlines.js. I was equally surprised not to have noticed it...

@all Could some of you verify it is now fixed at this link please? erikquinn.github.io/atc/b/missing-airlines

headphase commented 8 years ago

Seems to work for me!

It looks like I also may have accidentally not included an updated airlines.js and aircraft.js in my final commit in #431 ? odd.

erikquinn commented 8 years ago

@headphase okay, thanks. Looks like we are good to go. I will merge this now, and that should resolve this issue. Thanks for taking the time to verify the fix!

bolero3232 commented 8 years ago

Still not working for me.

headphase commented 8 years ago

@bolero3232 have you refreshed your browser cache? Typically CTRL+F5

bolero3232 commented 8 years ago

no effect dammit I liked this game

Fechulo commented 8 years ago

@bolero3232 Have you tried using incognito mode?

bolero3232 commented 8 years ago

I don't know what that is

Fechulo commented 8 years ago

If you're using Chrome you can open an incognito Window by pressing shift+ctrl+n

bolero3232 commented 8 years ago

No I just use IE. I think it's InPrivate here. No easy way to disable it. Anyway, nothing has changed in my system, so I don't think that's the problem.

erikquinn commented 8 years ago

@bolero3232 Are you definitely using http://zlsa.github.io/atc? Nobody seems to be having issues, so I'm not sure how to proceed here.

erikquinn commented 8 years ago

Apparently it's an Internet Explorer specific issue. Created a new issue for this, #450. @bolero3232 In the meantime, you may want to use a different browser (I recommend Google Chrome) until that is fixed.

erikquinn commented 8 years ago

hey @bolero3232, when you get a chance sometime, could you verify that the issue is fixed at this link?

erikquinn.github.io/atc/b/ie

This modified version of the sim includes the changes from PR #453 which should resolve your issue with Internet Explorer.

bolero3232 commented 8 years ago

I've just figured out I can run ATC with Microsoft Edge. Before this I was using IE. I have no clue why it won't run on IE anymore.

erikquinn commented 8 years ago

@bolero3232 Yes, the issue is unique to IE... But it should be resolved at the link I posted above. Please let me know whether or not that link works in IE for you so I can get it merged in.

erikquinn.github.io/atc/b/ie

bolero3232 commented 8 years ago

Yes, it does work! Thanks.

bolero3232 commented 8 years ago

erikquinn.github.io/atc/b/ie Error 404