search

zlsa / atc

https://openscope.co/
342 stars 107 forks source link

Issue #576 still broken for no-transition SIDs #649

Closed eliuuk closed 7 years ago

eliuuk commented 8 years ago

The fix to #576 only works for SIDs with transitions. Thanks to @erikquinn for clarifying this!

eliuuk commented 8 years ago

It might just be me, but it appears that I've somehow broken the fix to #576.

erikquinn commented 8 years ago

I noticed. It's not you, the fix works for SIDs with transitions, but not SIDs that dknt have transitions. I didn't think about this when checking the proposed fix, so it will need to be elaborated on to also work for SIDs with no transitions that overlap. Also, the idea was actually that SIDs should be implemented as a single entry, with corresponding "suffix" and "rwy" sections instead of one procedure for each. I believe the functionality of using the "suffix" property isnt built into the code and thats probably why you had to do it the way that you did. So we should probably get the suffix part working, which would make implementation of the sids section easier on you as well.

eliuuk commented 8 years ago

Yeah, the suffix part doesn't come through which is the reason why the SIDs I create are separate for each procedure.

erikquinn commented 7 years ago

@indianbhaji Is this still an existing issue?

eliuuk commented 7 years ago

I'll double check this tomorrow.

On 3 Jan 2017, 01:10 +0000, Erik Quinn notifications@github.com, wrote:

@indianbhaji (https://github.com/indianbhaji) Is this still an existing issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/zlsa/atc/issues/649#issuecomment-270038633), or mute the thread (https://github.com/notifications/unsubscribe-auth/ASgmWB14gCljhDEZz0Y2KZ5pnepjQnGrks5rOaAMgaJpZM4JpJ7w).

eliuuk commented 7 years ago

@erikquinn Yes

erikquinn commented 7 years ago

The ATC repository is being migrated to it's new home at https://github.com/openscope/openscope, and thus, all issues are being closed. If this is still an issue with the latest version of the sim (accessible at http://www.openscope.co), or is a feature you still think we are lacking, please reopen the issue at the new repo.

Please note that the vast majority of these issues have been copied to the new repository, or else are covered by other issues created there. See the below screenshot for what it looks like when your issue is known in the new repo:

image

Thank you!

Closing this issue.