zlsa / atc

https://openscope.co/
342 stars 107 forks source link

Negative elevations cannot be interpreted #657

Closed eliuuk closed 7 years ago

eliuuk commented 8 years ago

EHAM is (correct me if I am wrong) the only major airport that is under sea level, and during testing EHAM, the console states that it is unable to parse these negative elevations. http://prntscr.com/c8ymel

n8rzz commented 7 years ago

In v3 this now lives in .parseElevation() inside the utilities/unitConverters.js file.

This error is a result of how the elevations are being parsed with a regex. The Regex currently doesn't allow for negative numbers, thus, it fails an presents the error. /^(Infinity|(\d+(\.\d+)?)(m|ft))$/

We could move (or duplicate) this issue on the v3 issues board? Fixing this would be rather trivial, not to mention it provides a good excuse to refactor that function anyway.

n8rzz commented 7 years ago

See below issues for more information:

n8rzz commented 7 years ago

This issue is fixed by #702

erikquinn commented 7 years ago

Resolved by #702.