zlsa / atc

https://openscope.co/
342 stars 107 forks source link

LOWW issuing star command freezes the game #768

Closed georgeenciu closed 7 years ago

georgeenciu commented 7 years ago

Hello,

I have the following situation that happened twice already:

n8rzz commented 7 years ago

@georgeenciu @erikquinn quick first pass, the star command is erroring here:

screen shot 2016-12-22 at 1 28 25 pm

which seems odd because there is and entry segment. There is not an exit segment, though. When this fails, the current leg doesn't reset and when it tries to get the waypoints for what it thinks is the current leg, it fails because it doesn't exist.

Will continue investigating...

n8rzz commented 7 years ago

the other thing is that, as its written now, the command you included is actually invalid. The correct command should be: star balad.balad3k.loww. here is the definition for that route:

"BALAD3K": {
     "icao": "BALAD3K",
     "name": "Balad three kilo",
     "entryPoints": {
          "BALAD": ["BALAD"]
      },
     "body": [["BALAD", "A100|S250-"], ["WW669", "A60+|S250-"], ["WW665", "A60|S250-"], ["WW663", "A50|S250"], ["WW661", "A50|S250-"], ["WW659", "A50-|S250-"], ["WW657", "A50-|S250-"], ["WW655", "A50-|S250-"], ["WW653", "A50-|S250-"], ["WW652", "A50-|S250-"], ["WW651", "A50-|S250-"], ["WW650", "A50-|S250-"], ["RW11", "A50-|S250-"]],
     "draw": [["BALAD", "WW669", "WW665", "WW663", "WW661", "WW659", "WW657", "WW655", "WW653", "WW652", "WW651", "WW650"]]
},
n8rzz commented 7 years ago

even with the corrected command, it will still fail. so there is a legit problem here.

n8rzz commented 7 years ago

ultimately this fails because the currentWaypoint has a speed that is null. how that waypoint does not have a speed is a bit of a mystery.

this issue seems to logged already as #730 (https://github.com/n8rzz/atc/issues/138)

georgeenciu commented 7 years ago

This is odd. I had the same freeze issue, but I could issue commands. I issued the dvs command to a plane I just issued star nerdu.nerdu4k.loww and it unfreeze

georgeenciu commented 7 years ago

I've retested it and here is what I've got:

ghost commented 7 years ago

When you enter CAF to an already airborn plane it also freezes, I only played LOWW so far..

georgeenciu commented 7 years ago

didn't happened to me on cvs

ghost commented 7 years ago

I meant CAF (cleared as filed) dvs doesnt resume the game, LOWW running on Chrome

EDIT: It was a mistake that i entered this command to an already airborn plane, i was confused and choose the wrong one