search

zlsa / atc

https://openscope.co/
342 stars 107 forks source link

Refusal to takeoff #778

Closed dutchdavey closed 7 years ago

dutchdavey commented 7 years ago

Im getting sometimes, aircraft which wont budge from Waiting to takeoff, even if cvs or an altitude command has been given.

n8rzz commented 7 years ago

@dutchdavey could you provide a few more details?

dutchdavey commented 7 years ago

Chrome SFO taxi I don't know, in any case the aircraft remain unuseable. I dont know where that is, let me know and Ill check.. No, sim continues to work, but the aircraft are unuseable Playing for a while I'm still trying to reproduce it reliably

dutchdavey commented 7 years ago

Ive got 4 stuck at waiting right now.

dutchdavey commented 7 years ago

untitled

dutchdavey commented 7 years ago

Coulld it be related to a performance issue on a slow PC? Timeouts maybe?

this laptop slows appallingly once the sim has been running for some time.

n8rzz commented 7 years ago

Hmm. Do you still have the same problem if you taxi one aircraft, then clear it to takeoff? Do you get the same problem with all the aircraft waiting to takeoff? My guess is you are trying to clear an aircraft that is not first in line.

That console error suggests it could be a different issue, though.

n8rzz commented 7 years ago

just running through it quick I am unable to reproduce your issue, even after taxiing several aircraft and clearing them out of order.

The decreased performance is likely due to drawing the projected routes for all aircraft. That takes a lot of work to do, and the more aircraft the more power it needs. That will be improved in the future.

dutchdavey commented 7 years ago

I don't think its to do with a takeoff queue. As I said, once it happens, the affected aircraft won't take off, none of them, even if you wait a half hour.. I still have the same four waiting at the moment..

n8rzz commented 7 years ago

If you have the sim still paused, try and delete all the departures (or at least the ones that are stuck). You can do that by issuing a delete command: CALLSIGN del.

That will completely remove an aircraft from the sim and should clear the present log jam.

I'm more concerned with how you got to that spot. I haven't been able to reproduce this issue at all in any of our environments. Any additional information you can provide, or steps leading up to the issue, would help immensely in trying to spot where this is coming from.

dutchdavey commented 7 years ago

I decided at some point to use the command 'caf taxi' to get the aircraft to the takeoff runway, and then to use 'a 2 to' or 'a 3 to' or 'cvs to' to get them in the air, depending on the traffic. It seems, though I'm not sure, that this is where the anomaly started to appear.

Incidentally there isn't any log jam in any case. Aircraft still use both 28l and 28r! (The stopped planes remain stopped, rather like in Douglas Adams book)

dutchdavey commented 7 years ago

That doesnt seem to be relevant either, alas. I still get it with 'caf cvs taxi' followed by 'to'.

n8rzz commented 7 years ago

@dutchdavey I am still unable to reproduce this. Could you give it a try here: http://atc-dev.herokuapp.com

That is running my current develop branch and, in a few weeks, will be the next version released.

If you still get this error there, please provide a list of commands you used to cause the error. I am unable to reproduce this error by running the commands above.

dutchdavey commented 7 years ago

will do..

scott-j-smith commented 7 years ago

I had this problem too, and I'm also using Chrome. It can happen even if only issuing the 'w' or 'taxi' command to a single aircraft and not creating a queue. Because of the other bug where a landing arrival will cause a waiting departure to disappear, I have been making sure to only tell a flight to taxi when no arrivals are close to landing, and this issue where a flight will appear to taxi but won't take off happens. Usually when I see it, the plane won't appear on the screen even. And I was playing at a different airport than dutchdavey by the way. I will also try this on the dev branch linked above later tonight.

I can clear the issue by deleting the frozen departure and continuing to the next one.

scott-j-smith commented 7 years ago

@n8rzz I played for over 30 min. on timewarp 5 on LKPR on your development branch and could not replicate this issue there either, and I really tried to make it happen. Maybe one of the fixes for the other bugs also addressed this? I must say it was nice to play without worrying that waiting departures would disappear if another plane landed, or that every plane would change to heading 360 at the end of their assigned routes all the time. :-) Can't wait for 3.2.1 to merge to fix these issues.

n8rzz commented 7 years ago

@scott-j-smith Thanks for taking a look! I'm glad to hear you were not able to replicate. This feels like a sneaky issue and I'm not totally convinced that it is fixed in develop.

Perhaps there is a race condition somewhere? Perhaps this is a side effect of a completely different issue? I don't know. I'd love to say the glitch is gone, but I know better 😉

@dutchdavey did you have any luck reproducing in our develop env?

dutchdavey commented 7 years ago

No, I couldn't reproduce it either on development.

Looks to me like a classic automagical fix!

n8rzz commented 7 years ago

fixed-the-glitch

LeGiraffe commented 7 years ago

I have actually come across the same issue.

Running in any of the airports... Mac using Safari Multiple aircraft appear "waiting" and refuse to do anything.

It occurs when, you have used "Taxi" to a runway and they are "waiting" for "takeoff". If a arriving aircraft lands, at the moment it is cleared and "contacting ground" appears, all aircraft on the airport waiting are partially removed (radar tag), whilst the strip remains.

Perhaps something is clearing all traffic on the airport instead of just the aircraft that has landed.

scott-j-smith commented 7 years ago

@matt5611
I think that is a different bug that I reported earlier too. The bug discussed in this issue is not related to the case where an aircraft lands and the waiting plane is removed from radar and then can't take off.

scott-j-smith commented 7 years ago

@n8rzz Nate - your development branch code might have an issue with the collision warning (white) and alert (red) circles not working. I was playing OTHH and two aircraft coming in on different arrival STAR's ended up almost colliding at the same altitude and speed -- no warnings were shown. See screen shot below.

Flights QTR4205 on the AFNAN arrival, and QTR3894 on the BAYAN arrival.

image

n8rzz commented 7 years ago

hmm, thanks @scott-j-smith! Could you open an issue in my fork for that (with that screenshot)? That looks like it could be a side effect from one of the features completed this sprint.

re: @erikquinn

scott-j-smith commented 7 years ago

@n8rzz Done!

erikquinn commented 7 years ago

@matt5611: It occurs when, you have used "Taxi" to a runway and they are "waiting" for "takeoff". If a arriving aircraft lands, at the moment it is cleared and "contacting ground" appears, all aircraft on the airport waiting are partially removed (radar tag), whilst the strip remains.

@scott-j-smith: @matt5611 I think that is a different bug that I reported earlier too. The bug discussed in this issue is not related to the case where an aircraft lands and the waiting plane is removed from radar and then can't take off.

I concur with @matt5611. This is almost definitely a similar symptom to that described in #770; both symptoms are resolved following n8rzz/atc#241. This also explains why it is broken at zlsa/gh-pages, but working at n8rzz/develop. When #776 (v3.2.1) is merged, this will be resolved.