search

zlsecure3 / review_Aark

0 stars 0 forks source link

`_fee` calculation can be simplified in `LpLogic::updatePaidValue()` function #19

Open zlsecure3 opened 1 year ago

zlsecure3 commented 1 year ago

subject

_fee calculation can be simplified in LpLogic::updatePaidValue() function

description

_fee = _paidValueDelta - (_paidValueDelta * (10000 - feeRate)) / 10000;

is the same as :

_fee = _paidValueDelta * feeRate / 10000;

Similar for calculation of _feeToProtocol in LpLogic::updateGlobalEntryValue.

recommendation

Apply the above optimization.

locations

severity

Informational

damage

exploitability

category

Code Style

system_generated: auditor:alansh submission_id:1762152798

zlsecure3 commented 1 year ago

grading (edit)

submission_id:1762152798

review_type:GRADING

result: TBD-yes,no

rating: TBD-123

comment: TBD-Rejected,Accepted by Secure3.

severity: TBD-Critical,Medium,Low,Informational

category:

description:

zlsecure3 commented 1 year ago

client feedback (manual copy)

submission_id:1762152798

review_type:CLIENT_FEEDBACK

result: TBD-yes,no

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 commented 1 year ago

client feedback decision(edit)

submission_id:1762152798

review_type:CLIENT_FEEDBACK_DECISION

result: TBD-yes,no,yes-honored,no-honored

severity: TBD-Critical,Medium,Low,Informational

comment: