search

zlsecure3 / review_Aark

0 stars 0 forks source link

`MAX_VALID_INITIAL_MARGIN_FRACTION` should be 10000 in `MarketConfig` library #23

Open zlsecure3 opened 1 year ago

zlsecure3 commented 1 year ago

subject

MAX_VALID_INITIAL_MARGIN_FRACTION should be 10000 in MarketConfig library

description

Since 10000 means 100%, it doesn't make sense to allow higher . (search 16383 for a complete list)

recommendation

Change MAX_VALID_INITIAL_MARGIN_FRACTION to 10000

locations

severity

Informational

damage

exploitability

category

Integer Overflow and Underflow

system_generated: auditor:alansh submission_id:1762161847

zlsecure3 commented 1 year ago

grading (edit)

submission_id:1762161847

review_type:GRADING

result: TBD-yes,no

rating: TBD-123

comment: TBD-Rejected,Accepted by Secure3.

severity: TBD-Critical,Medium,Low,Informational

category:

description:

zlsecure3 commented 1 year ago

client feedback (manual copy)

submission_id:1762161847

review_type:CLIENT_FEEDBACK

result: TBD-yes,no

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 commented 1 year ago

client feedback decision(edit)

submission_id:1762161847

review_type:CLIENT_FEEDBACK_DECISION

result: TBD-yes,no,yes-honored,no-honored

severity: TBD-Critical,Medium,Low,Informational

comment: