InsuranceManager, TierStorage, ContractReader missing inheritance

zlsecure3 commented 1 year ago

subject

description

InsuranceManager should inherit from IInsuranceManager, TierStorage should inherit from ITierStorage ContractReader should inherit from IPriceOracle, NonTransferableToken should inherit from IToken.

recommendation

Change as follow

InsuranceManager

import {IInsuranceManager} from "../../interfaces/managers/IInsuranceManager.sol";
contract InsuranceManager is Multicall, Initializable, InsuranceStorage, IInsuranceManager {
......
}

TierStorage

import {ITierStorage} from "../../interfaces/storages/ITierStorage.sol";
contract TierStorage is AccessController, Initializable, ITierStorage {
......
}

ContractReader

import {IPriceOracle} from "../../interfaces/oracle/IPriceOracle.sol";
contract ContractReader is IPriceOracle { 
.....
}

locations

contracts/core/managers/InsuranceManager.sol#L26-186 contracts/interfaces/managers/IInsuranceManager.sol#L8-10 contracts/core/storages/TierStorage.sol#L19-111 contracts/interfaces/storages/ITierStorage.sol#L8-13 contracts/core/utils/ContractReader.sol#L20-160 contracts/interfaces/oracle/IPriceOracle.sol#L8-10

severity

Medium

damage

exploitability

grading (edit)

submission_id:1755230337

review_type:GRADING

result: TBD-yes,no

rating: TBD-123

comment: TBD-Rejected,Accepted by Secure3.

severity: TBD-Critical,Medium,Low,Informational

category:

description:

zlsecure3 commented 1 year ago

client feedback (manual copy)

submission_id:1755230337

review_type:CLIENT_FEEDBACK

result: TBD-yes,no

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 commented 1 year ago

client feedback decision(edit)

submission_id:1755230337

review_type:CLIENT_FEEDBACK_DECISION

result: TBD-yes,no,yes-honored,no-honored

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 / review_Aark