search

zlsecure3 / review_Aark

0 stars 0 forks source link

wrong comment for `sender` in both `LpManager::addCollateral` and `FuturesManager::addCollateral` #7

Open zlsecure3 opened 1 year ago

zlsecure3 commented 1 year ago

subject

wrong comment for sender in both LpManager::addCollateral and FuturesManager::addCollateral

description

The comment says that sender parameter Must be the Router., but in fact at the caller side MasterRouter::addCollateral it can be either the router of the user depending on whether msg.value is zero.

recommendation

Remove the Must be the Router. comment for misleading.

locations

severity

Informational

damage

exploitability

category

Code Style

system_generated: auditor:alansh submission_id:1757122062

zlsecure3 commented 1 year ago

grading (edit)

submission_id:1757122062

review_type:GRADING

result: TBD-yes,no

rating: TBD-123

comment: TBD-Rejected,Accepted by Secure3.

severity: TBD-Critical,Medium,Low,Informational

category:

description:

zlsecure3 commented 1 year ago

client feedback (manual copy)

submission_id:1757122062

review_type:CLIENT_FEEDBACK

result: TBD-yes,no

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 commented 1 year ago

client feedback decision(edit)

submission_id:1757122062

review_type:CLIENT_FEEDBACK_DECISION

result: TBD-yes,no,yes-honored,no-honored

severity: TBD-Critical,Medium,Low,Informational

comment: