could save some gas in `CommonManager::_removeCollateral` function

zlsecure3 commented 1 year ago

subject

could save some gas in CommonManager::_removeCollateral function

description

            require(vars.collateralQty >= args.amount, "Insufficient balance");
            vars.collateralQty -= args.amount;

could be changed to:

            require(vars.collateralQty >= args.amount, "Insufficient balance");
            unchecked {vars.collateralQty -= args.amount;}

Since the require statement already ensures overflow will not happen.

recommendation

Apply the above optimization.

locations

code/contracts/core/managers/CommonManager.sol#L219

severity

Informational

damage

exploitability

grading (edit)

submission_id:1757175544

review_type:GRADING

result: TBD-yes,no

rating: TBD-123

comment: TBD-Rejected,Accepted by Secure3.

severity: TBD-Critical,Medium,Low,Informational

category:

description:

zlsecure3 commented 1 year ago

client feedback (manual copy)

submission_id:1757175544

review_type:CLIENT_FEEDBACK

result: TBD-yes,no

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 commented 1 year ago

client feedback decision(edit)

submission_id:1757175544

review_type:CLIENT_FEEDBACK_DECISION

result: TBD-yes,no,yes-honored,no-honored

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 / review_Aark