search

zlsecure3 / review_star

0 stars 0 forks source link

No need for ex_expire_time in `StarNameService` contract `renew_name_script` function #18

Open zlsecure3 opened 1 year ago

zlsecure3 commented 1 year ago

subject

No need for ex_expire_time in StarNameService contract renew_name_script function

description

ex_expire_time is the same as expire_time, just use expire_time to save some gas.

recommendation

Use expire_time instead.

locations

severity

Informational

damage

exploitability

category

Gas Optimization

system_generated: auditor:alansh submission_id:1465021738

zlsecure3 commented 1 year ago

grading (edit)

submission_id:1465021738

review_type:GRADING

result: TBD-yes,no

rating: TBD-123

comment: TBD-Rejected,Accepted by Secure3.

severity: TBD-Critical,Medium,Low,Informational

category:

description:

zlsecure3 commented 1 year ago

client feedback (manual copy)

submission_id:1465021738

review_type:CLIENT_FEEDBACK

result: TBD-yes,no

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 commented 1 year ago

client feedback decision(edit)

submission_id:1465021738

review_type:CLIENT_FEEDBACK_DECISION

result: TBD-yes,no,yes-honored,no-honored

severity: TBD-Critical,Medium,Low,Informational

comment: